Jackie-Jiang commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r327731629
########## File path: pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/NullValueTransformer.java ########## @@ -22,28 +22,45 @@ import org.apache.pinot.common.data.FieldSpec; import org.apache.pinot.common.data.Schema; import org.apache.pinot.core.data.GenericRow; +import org.roaringbitmap.RoaringBitmap; + +import static org.apache.pinot.common.utils.CommonConstants.Segment.NULL_FIELDS; Review comment: (minor) please don't use static import for non-testing class. Same for other classes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
