Jackie-Jiang commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r338325693
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/RealtimeSegmentConfig.java
##########
@@ -40,13 +40,25 @@
private final RealtimeSegmentStatsHistory _statsHistory;
private final SegmentPartitionConfig _segmentPartitionConfig;
private final boolean _aggregateMetrics;
+ private final boolean _nullHandlingEnabled;
private RealtimeSegmentConfig(String segmentName, String streamName, Schema
schema, int capacity,
int avgNumMultiValues, Set<String> noDictionaryColumns, Set<String>
varLengthDictionaryColumns,
Set<String> invertedIndexColumns, RealtimeSegmentZKMetadata
realtimeSegmentZKMetadata,
boolean offHeap, PinotDataBufferMemoryManager memoryManager,
RealtimeSegmentStatsHistory statsHistory, SegmentPartitionConfig
segmentPartitionConfig,
boolean aggregateMetrics) {
+ this(segmentName, streamName, schema, capacity, avgNumMultiValues,
noDictionaryColumns, varLengthDictionaryColumns,
+ invertedIndexColumns, realtimeSegmentZKMetadata, offHeap,
memoryManager, statsHistory, segmentPartitionConfig,
+ aggregateMetrics, false);
+ }
+
+ private RealtimeSegmentConfig(String segmentName, String streamName, Schema
schema, int capacity,
Review comment:
You don't need two constructors as it is private and always constructed from
the builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
