J-HowHuang commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2848117820
Before this PR, if we set `externalViewStabilizationTimeoutInMs=10000ms`, regular run will fail after 10000ms wait, while bestEfforts continue the next step after 10000ms. In this PR, regular run will succeed after, for example, 150000ms (extended 14 times), while bestEfforts continue the next step after 10000ms. All of this is because current PR will not give any timeout extension to `bestEfforts=true`. What I suggested is to allow bestEfforts to have this dynamic timeout too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
