rohityadav1993 commented on code in PR #16086:
URL: https://github.com/apache/pinot/pull/16086#discussion_r2151915159
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java:
##########
@@ -462,4 +464,10 @@ protected String
getSegmentCrcList(List<SegmentMergerMetadata> segmentMergerMeta
segmentMergerMetadataList.stream().map(x ->
String.valueOf(x.getSegmentZKMetadata().getCrc()))
.collect(Collectors.toList()), ",");
}
+
+ @VisibleForTesting
+ protected long getMaxCreationTimeMillis(List<SegmentMergerMetadata>
segmentMergerMetadataList) {
Review Comment:
Should we fail instead of returning -1? Also, we can be explicit by naming
this getMaxZKCreationTimeMillis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
