tarun11Mavani commented on code in PR #16086:
URL: https://github.com/apache/pinot/pull/16086#discussion_r2153752567
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java:
##########
@@ -202,4 +194,32 @@ void validateCRCForInputSegments(List<SegmentMetadataImpl>
segmentMetadataList,
}
}
}
+
+ /**
+ * Retrieves the max ZK creation time from task configuration with proper
null handling.
+ *
+ * @param configs Task configuration map
+ * @return Max ZK creation time in milliseconds
+ * @throws IllegalStateException if the configuration value is invalid
+ */
+ long getMaxZKCreationTimeFromConfig(Map<String, String> configs) {
+ String maxCreationTimeStr =
configs.get(MinionConstants.UpsertCompactMergeTask.MAX_ZK_CREATION_TIME_MILLIS_KEY);
+ if (maxCreationTimeStr == null) {
+ String message = "Max creation time configuration is missing from task
config.";
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
