J-HowHuang commented on code in PR #16096:
URL: https://github.com/apache/pinot/pull/16096#discussion_r2152858088
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -473,6 +492,10 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
// StrictReplicaGroupAssignment::rebalanceTable() and similar limitations
apply here as well
Object2IntOpenHashMap<String> segmentPartitionIdMap = new
Object2IntOpenHashMap<>();
+ boolean isStrictRealtimeSegmentAssignment = (segmentAssignment instanceof
StrictRealtimeSegmentAssignment);
+ PartitionIdFetcher partitionIdFetcher =
+ new PartitionIdFetcherImpl(tableNameWithType,
TableConfigUtils.getPartitionColumn(tableConfig), _helixManager,
+ isStrictRealtimeSegmentAssignment);
// We repeat the following steps until the target assignment is reached:
// 1. Wait for ExternalView to converge with the IdealState. Fail the
rebalance if it doesn't converge within the
// timeout.
Review Comment:
Also added relevant texts for batch size per server.
cc @somandal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
