J-HowHuang commented on PR #16096: URL: https://github.com/apache/pinot/pull/16096#issuecomment-2981634551
Thanks for the reviews @yashmayya and @somandal , most of the comments are addressed from [e3b7893](https://github.com/apache/pinot/pull/16096/commits/e3b789364a626d3813d8890d34dc6bd7cb4628be) and on. Discussions: 1. Should we fail the rebalance job if force commit throws exception? 2. Right now I expose force commit batch size and timeout to the UI, keeping force commit check interval to the API (as other similar parameters), and default the values to what they are in the forceCommit API. Is this good? 3. What should we name the `forceCommitBeforeMoved` parameter in the API? I feel like `forceCommit` lacks its context a bit, but not strongly against it though. Also, updated the UI and added preview in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
