somandal commented on code in PR #16094:
URL: https://github.com/apache/pinot/pull/16094#discussion_r2201157111
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java:
##########
@@ -94,6 +101,27 @@ public void add(String jsonString)
addFlattenedRecords(JsonUtils.flatten(jsonString, _jsonIndexConfig));
Review Comment:
@Jackie-Jiang @gortiz there is a complication in using the `continueOnError`
flag for `JsonUtils.flatten()` call here as this is also called from
`MutableJsonIndexImpl` where I don't have access to the TableConfig /
IngestionConfig to get the `continueOnError` flag value.
To try and pass that in somehow would require a lot of interface changes
which doesn't seem straightforward. Any ideas on how to solve for this?
If you want, I can just use this `continueOnError` flag for the `add(Map
value)` function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
