somandal commented on code in PR #16094:
URL: https://github.com/apache/pinot/pull/16094#discussion_r2201246838


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java:
##########
@@ -91,7 +98,36 @@ public abstract class BaseJsonIndexCreator implements 
JsonIndexCreator {
   @Override
   public void add(String jsonString)
       throws IOException {
-    addFlattenedRecords(JsonUtils.flatten(jsonString, _jsonIndexConfig));
+    List<Map<String, String>> flattenedRecord = JsonUtils.flatten(jsonString, 
_jsonIndexConfig);
+    if (flattenedRecord.equals(JsonUtils.SKIPPED_FLATTENED_RECORD)) {

Review Comment:
   @gortiz @Jackie-Jiang just FYI that I've added additional code to check if 
`JsonUtils.flatten` returned the SKIPPED record and I update the metric in that 
case. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to