This is an automated email from the ASF dual-hosted git repository.
kharekartik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a9bf0cc886f Fix logger for pauseless (#16593)
a9bf0cc886f is described below
commit a9bf0cc886f5e65226957c69e9f70695b7152ee7
Author: 9aman <[email protected]>
AuthorDate: Thu Aug 14 14:32:40 2025 +0530
Fix logger for pauseless (#16593)
* Change logger being used to easily verify whether pauseless is enabled
are not using logs
* fix typo
---
.../controller/helix/core/realtime/BlockingSegmentCompletionFSM.java | 5 ++---
.../helix/core/realtime/PauselessSegmentCompletionFSM.java | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java
index 7a0a050858c..f828059aae0 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/BlockingSegmentCompletionFSM.java
@@ -57,7 +57,6 @@ import org.slf4j.LoggerFactory;
* See https://github.com/linkedin/pinot/wiki/Low-level-kafka-consumers
*/
public class BlockingSegmentCompletionFSM implements SegmentCompletionFSM {
- public static final Logger LOGGER =
LoggerFactory.getLogger(BlockingSegmentCompletionFSM.class);
public enum BlockingSegmentCompletionFSMState {
PARTIAL_CONSUMING, // Indicates that at least one replica has reported
that it has stopped consuming.
@@ -130,7 +129,7 @@ public class BlockingSegmentCompletionFSM implements
SegmentCompletionFSM {
if (savedCommitTime != null && savedCommitTime > initialCommitTimeMs) {
initialCommitTimeMs = savedCommitTime;
}
- _logger = LoggerFactory.getLogger("SegmentCompletionFSM_" +
segmentName.getSegmentName());
+ _logger = LoggerFactory.getLogger(this.getClass().getSimpleName() + "_" +
segmentName.getSegmentName());
int maxCommitTimeForAllSegmentsSeconds =
SegmentCompletionManager.getMaxCommitTimeForAllSegmentsSeconds();
if (initialCommitTimeMs > maxCommitTimeForAllSegmentsSeconds * 1000L) {
// The table has a really high value configured for max commit time. Set
it to a higher value than default
@@ -771,7 +770,7 @@ public class BlockingSegmentCompletionFSM implements
SegmentCompletionFSM {
// The winner is coming back to report its offset. Take a decision based
on the offset reported, and whether we
// already notified them
// Winner is supposedly already in the commit call. Something wrong.
- LOGGER.warn(
+ _logger.warn(
"{}:Aborting FSM because winner is reporting a segment while it is
also committing instance={} offset={} "
+ "now={}", _state, instanceId, offset, now);
// Ask them to hold, just in case the committer fails for some reason..
diff --git
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PauselessSegmentCompletionFSM.java
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PauselessSegmentCompletionFSM.java
index c1112f86489..2e6727b3c17 100644
---
a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PauselessSegmentCompletionFSM.java
+++
b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PauselessSegmentCompletionFSM.java
@@ -46,8 +46,8 @@ public class PauselessSegmentCompletionFSM extends
BlockingSegmentCompletionFSM
try {
CommittingSegmentDescriptor committingSegmentDescriptor =
CommittingSegmentDescriptor.fromSegmentCompletionReqParams(reqParams);
- LOGGER.info(
- "Starting to commit changes to ZK and ideal state for the segment:{}
during pauseles ingestion as the "
+ _logger.info(
+ "Starting to commit changes to ZK and ideal state for the segment:{}
during pauseless ingestion as the "
+ "leader has been selected", _segmentName);
_segmentManager.commitSegmentMetadataToCommitting(
TableNameBuilder.REALTIME.tableNameWithType(_segmentName.getTableName()),
committingSegmentDescriptor);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
