gortiz opened a new pull request, #16595: URL: https://github.com/apache/pinot/pull/16595
We have found issues cancelling queries while blocks are serialized. This is because the serialization process requires heavy computation whose cost is proportional to the length of the block, and there is no check while doing that on whether the thread has been interrupted or not. The change is very simple: Divide the execution into two loops. The outer checks if the thread has been interrupted while the inner runs for a fixed number of rows. This reduces the cost of checking interruption while keeping the number of rows evaluated constant without checking. This PR also improves the exception reported in two cases. Specifically, I found that the stack trace was lost when Exceptions are transformed into error blocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
