J-HowHuang commented on code in PR #16624:
URL: https://github.com/apache/pinot/pull/16624#discussion_r2283666695
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java:
##########
@@ -180,6 +183,11 @@ public ComplexTypeTransformer build() {
}
}
+ @Override
+ public void withInputColumnsOfDownStreamTransformers(Collection<String>
columns) {
+ _fieldsNeededForDownstreamTransformers = new HashSet<>(columns);
Review Comment:
We pass in the cumulative set, which will change when the set roll up to
upstream transformers, so we need a deep copy here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
