Jackie-Jiang commented on code in PR #16624:
URL: https://github.com/apache/pinot/pull/16624#discussion_r2285861163
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java:
##########
@@ -180,6 +183,11 @@ public ComplexTypeTransformer build() {
}
}
+ @Override
+ public void withInputColumnsOfDownStreamTransformers(Collection<String>
columns) {
+ _fieldsNeededForDownstreamTransformers = new HashSet<>(columns);
Review Comment:
Good point. We should also add this to the javadoc of the interface where
the passed in set can be modified.
I'm thinking making a `Set<String>` of common columns of `_fieldsToUnnest`
and this set, which is used to decide wether to keep the original column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
