9aman commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2284372684
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java:
##########
@@ -95,4 +95,8 @@ default boolean isEndOfPartitionGroup() {
default boolean hasDataLoss() {
return false;
}
+
+ default long getSizeInBytes() {
Review Comment:
We don't have a default implementation for getMessageCount. Suggest removing
this default implementation.
We can use
```
public int getSizeInBytes() {
return _values.stream()
.mapToInt(byteArray -> byteArray.length)
.sum();
}
```
in the FakeStreamMessageBatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
