9aman commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2284350452
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/test/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProviderTest.java:
##########
@@ -170,7 +170,7 @@ public void getPartitionsGroupInfoEndOfShardTest()
when(_streamConsumerFactory.createPartitionGroupConsumer(stringCapture.capture(),
partitionGroupMetadataCapture.capture())).thenReturn(_partitionGroupConsumer);
when(_partitionGroupConsumer.fetchMessages(checkpointArgs.capture(),
intArguments.capture())).thenReturn(
- new KinesisMessageBatch(new ArrayList<>(),
kinesisPartitionGroupOffset, true));
+ new KinesisMessageBatch(new ArrayList<>(),
kinesisPartitionGroupOffset, true, 0));
Review Comment:
Is there a way to test the batch size functionality? Mocking response, using
data etc ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
