gortiz commented on code in PR #16576:
URL: https://github.com/apache/pinot/pull/16576#discussion_r2299721518
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -223,6 +232,25 @@ protected Map<String, Plan.ExplainNode.AttributeValue>
getExplainAttributes() {
return Collections.emptyMap();
}
+ private long getGcTimeMillis() {
Review Comment:
I also thought about that, but as you said there is no much we can do. On
the other hand:
1. If we end up having full gcs due to the query, this may be useful
(although GCs _produced_ by a stage will also affect other stages on the same
machine).
2. Even if concurrent GC is dominant... that is a useful right? Even if we
don't stop the world, during that time we had less CPUs available for the
program. Again, the stat on one stage will be affected by others, but it may be
better than nothing. Given it is disabled by default, I think it is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
