bziobrowski commented on code in PR #16576:
URL: https://github.com/apache/pinot/pull/16576#discussion_r2303792013
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java:
##########
@@ -223,6 +232,25 @@ protected Map<String, Plan.ExplainNode.AttributeValue>
getExplainAttributes() {
return Collections.emptyMap();
}
+ private long getGcTimeMillis() {
Review Comment:
I do agree to some extent but still believe that there'll be too much noise
for this stat to be useful (vs checking gc stats in grafana). Maybe it'd be
better to use jfr api and capture select stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
