gortiz commented on code in PR #16595:
URL: https://github.com/apache/pinot/pull/16595#discussion_r2299985655
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java:
##########
@@ -91,93 +91,95 @@ public static RowDataBlock buildFromRows(List<Object[]>
rows, DataSchema dataSch
PagedPinotOutputStream varSize = new PagedPinotOutputStream(allocator);
Object2IntOpenHashMap<String> dictionary = new Object2IntOpenHashMap<>();
- for (int rowId = 0; rowId < numRows; rowId++) {
- Object[] row = rows.get(rowId);
- for (int colId = 0; colId < numColumns; colId++) {
- Object value = row[colId];
- ColumnDataType storedType = storedTypes[colId];
+ interruptableLoop(0, numRows, 1000, (start, end) -> {
Review Comment:
The other loops use 10k step size because they just iterate over one column.
Here we iterate over the whole table, so I decided to use 1k step size. I
didn't run any benchmark, just decided to use a smaller number here for that
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
