somandal commented on code in PR #14250:
URL: https://github.com/apache/pinot/pull/14250#discussion_r2304362060
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##########
@@ -488,24 +496,24 @@ private Pair<String, String>
generateValidDocIdsMetadataURL(String tableNameWith
return Pair.of(url, jsonTableSegments);
}
- private String generateColumnsParam(List<String> columns) {
+ private String generateStaleSegmentsServerURL(String tableNameWithType,
String endpoint) {
+ tableNameWithType = URLEncoder.encode(tableNameWithType,
StandardCharsets.UTF_8);
+ return String.format("%s/tables/%s/segments/isStale", endpoint,
tableNameWithType);
+ }
+
+ private String generateParam(List<String> values, String key) {
Review Comment:
nit: can we reorder the parameters, key first and then values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
