somandal commented on code in PR #14250:
URL: https://github.com/apache/pinot/pull/14250#discussion_r2316605185
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -926,8 +926,10 @@ private void deleteSegmentsInternal(String
tableNameWithType, List<String> segme
public String getServerMetadata(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
@ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
- @ApiParam(value = "Columns name", allowMultiple = true)
@QueryParam("columns") @DefaultValue("")
- List<String> columns, @Context HttpHeaders headers) {
+ @Encoded @ApiParam(value = "Segments to include", allowMultiple = true)
@QueryParam("segments")
+ @Nullable List<String> segments,
+ @Encoded @ApiParam(value = "Columns name", allowMultiple = true)
@QueryParam("columns")
+ @Nullable List<String> columns, @Context HttpHeaders headers) {
tableName = DatabaseUtils.translateTableName(tableName, headers);
LOGGER.info("Received a request to fetch metadata for all segments for
table {}", tableName);
Review Comment:
nit: should this be updated to call out "all segments" only if segments is
empty? and otherwise log the number of segments?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -926,8 +926,10 @@ private void deleteSegmentsInternal(String
tableNameWithType, List<String> segme
public String getServerMetadata(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
@ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
- @ApiParam(value = "Columns name", allowMultiple = true)
@QueryParam("columns") @DefaultValue("")
- List<String> columns, @Context HttpHeaders headers) {
+ @Encoded @ApiParam(value = "Segments to include", allowMultiple = true)
@QueryParam("segments")
Review Comment:
nit: should we call out that if this is empty, it fetches for all segments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
