yashmayya commented on code in PR #16983:
URL: https://github.com/apache/pinot/pull/16983#discussion_r2421877442


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -3631,7 +3631,13 @@ public void testNonScanAggregationQueries(boolean 
useMultiStageQueryEngine)
     testNonScanAggregationQuery(query, h2Query);
 
     // STRING
-    // TODO: add test cases for string column when we add support for min and 
max on string datatype columns
+    query = "SELECT MINSTRING(Carrier) FROM " + tableName;

Review Comment:
   https://github.com/apache/pinot/pull/16980 hasn't been merged though, so we 
don't have query re-write yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to