yashmayya commented on code in PR #16983:
URL: https://github.com/apache/pinot/pull/16983#discussion_r2418090849
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java:
##########
@@ -99,15 +99,23 @@ protected AggregationResultsBlock getNextBlock() {
break;
case MIN:
case MINMV:
- result = getMinValue(dataSource);
+ result = getMinValueNumeric(dataSource);
+ break;
+ case MINSTRING:
+ result = dataSource.getDictionary() != null ?
dataSource.getDictionary().getMinVal()
+ : dataSource.getDataSourceMetadata().getMinValue();
Review Comment:
I'm guessing you're referring to this -
https://github.com/apache/pinot/blob/ce33d0d918485e3aae6b42ee72c428d02672409e/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java#L814-L820
The value too long case is handled by the `null` check here -
https://github.com/apache/pinot/blob/ce33d0d918485e3aae6b42ee72c428d02672409e/pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationPlanNode.java#L193-L199
And the special character thing is also handled when building the column
metadata -
https://github.com/apache/pinot/blob/ce33d0d918485e3aae6b42ee72c428d02672409e/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java#L291-L298
,
https://github.com/apache/pinot/blob/ce33d0d918485e3aae6b42ee72c428d02672409e/pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java#L532-L533
Am I missing anything else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
