suvodeep-pyne opened a new pull request, #17051:
URL: https://github.com/apache/pinot/pull/17051
## Summary
This PR refactors the table reload status API to improve code organization
and clarity through three commits:
1. **Refactor reload job status logic**: Extracted reload job status logic
from `PinotTableReloadResource` into a dedicated
`PinotTableReloadStatusReporter` class to improve separation of concerns and
maintainability.
2. **Chain setters for simplification**: Updated
`ServerReloadControllerJobStatusResponse` to use fluent-style chained setters,
simplifying the code and eliminating redundant intermediate response object
creation.
3. **Rename response class**: Renamed
`ServerReloadControllerJobStatusResponse` to `PinotTableReloadStatusResponse`
and moved it from `org.apache.pinot.controller.api.resources` to
`org.apache.pinot.controller.api.dto` package for better semantic clarity and
proper API structure organization.
### Changes
- Renamed class: `ServerReloadControllerJobStatusResponse` →
`PinotTableReloadStatusResponse`
- Moved package: `org.apache.pinot.controller.api.resources` →
`org.apache.pinot.controller.api.dto`
- Updated all references across:
- `PinotTableReloadResource.java`
- `PinotTableReloadStatusReporter.java`
- `PartialUpsertTableRebalanceIntegrationTest.java`
- `TableRebalanceIntegrationTest.java`
- Introduced dedicated `PinotTableReloadStatusReporter` service class for
better code organization
- Implemented fluent-style chained setters for cleaner code
- Fixed variable naming: `segmnetNameList` → `segmentNames` and
`segmentNames` parameter → `segmentNamesString`
### Testing
- All existing integration tests updated and pass
- No functional changes to the reload status API behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
