suvodeep-pyne commented on code in PR #17051:
URL: https://github.com/apache/pinot/pull/17051#discussion_r2453160982
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/dto/PinotTableReloadStatusResponse.java:
##########
@@ -16,24 +16,22 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.controller.api.resources;
+package org.apache.pinot.controller.api.dto;
-import java.util.Map;
-
-public class ServerReloadControllerJobStatusResponse {
+public class PinotTableReloadStatusResponse {
Review Comment:
The reason I removed it is because, it is the same object used by both
Controller and Server responses. If we need different classes, then I'd name
them accordingly.
In the server code `ControllerJobStatusResource` actually uses another POJO
`SegmentReloadStatusValue` for this and not `PinotTableReloadStatusResponse`.
It can lead to inconsistencies and I'm thinking to centralizing some of these
DTOs in a later PR.
thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
