Jackie-Jiang commented on code in PR #17145: URL: https://github.com/apache/pinot/pull/17145#discussion_r2557653120
########## pinot-core/src/main/java/org/apache/pinot/core/routing/FederationProvider.java: ########## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.routing; + +import java.util.Map; +import org.apache.pinot.common.config.provider.TableCache; + + +/** + * A generic class which provides the dependencies for federation routing. + */ +public class FederationProvider { + // Maps clusterName to TableCache. + Map<String, TableCache> _tableCacheMap; Review Comment: (minor) `private final` ########## pinot-core/src/main/java/org/apache/pinot/core/routing/FederationProvider.java: ########## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.routing; + +import java.util.Map; +import org.apache.pinot.common.config.provider.TableCache; + + +/** + * A generic class which provides the dependencies for federation routing. + */ +public class FederationProvider { Review Comment: This name is too general. Rename it to something more specific, e.g. `CrossClusterRoutingInfoProvider` ########## pinot-spi/src/main/java/org/apache/pinot/spi/data/PhysicalTableConfig.java: ########## @@ -26,4 +27,40 @@ * This is empty by design and more docs would be added as features are added. */ public class PhysicalTableConfig extends BaseJsonConfig { + @JsonProperty("isFederated") + boolean _isFederated; Review Comment: Is there a concept of federated physical table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
