shauryachats commented on code in PR #17145:
URL: https://github.com/apache/pinot/pull/17145#discussion_r2578574040
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/PhysicalTableConfig.java:
##########
@@ -26,4 +27,40 @@
* This is empty by design and more docs would be added as features are added.
*/
public class PhysicalTableConfig extends BaseJsonConfig {
+ @JsonProperty("isFederated")
+ boolean _isFederated;
Review Comment:
Yes we do, because since the controller does not know which tables are
federated or not, the controller can skip physical table validations only for
physical tables which are federated, when the logical table is created or
updated.
Furthermore, there might be a case where we want to selectively federate
only some physical tables in a logical table and for other physical tables
which are explicitly set to non-federated (by `isFederated = false`), we will
not consider that table for federation even if the same physical table name is
also present cross-cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
