Jackie-Jiang commented on code in PR #17258:
URL: https://github.com/apache/pinot/pull/17258#discussion_r2566626435
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -158,7 +158,7 @@ public QueryEnvironment(Config config) {
_catalogReader = new PinotCatalogReader(
rootSchema, List.of(database), _typeFactory, CONNECTION_CONFIG,
config.isCaseSensitive());
// default optProgram with no skip rule options and no use rule options
- _optProgram = getOptProgram(Set.of(), Set.of());
+ _optProgram = getOptProgram(Set.of(), Set.of(), new
HashSet<>(_envConfig.defaultDisabledMseRules()));
Review Comment:
(minor) default disabled rules can be a final member variable
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -422,6 +422,10 @@ private ImmutableQueryEnvironment.Config
getQueryEnvConf(HttpHeaders httpHeaders
CommonConstants.Helix.ENABLE_CASE_INSENSITIVE_KEY,
CommonConstants.Helix.DEFAULT_ENABLE_CASE_INSENSITIVE
);
+ List<String> defaultDisabledRules = _config.getProperty(
Review Comment:
Let's directly make it a `Set` to avoid the overhead of constructing a Set
over this List at query time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
