Jackie-Jiang commented on code in PR #17258:
URL: https://github.com/apache/pinot/pull/17258#discussion_r2566633619
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -908,7 +908,7 @@ public static class PlannerRuleNames {
* If a rule is enabled and disabled at the same time,
* it will be disabled
*/
- public static final Set<String> DEFAULT_DISABLED_RULES = Set.of(
+ public static final List<String> DEFAULT_DISABLED_RULES = List.of(
Review Comment:
We shouldn't need to change this if we directly use a `Set` in
`QueryEnvironment` config. Immutable set probably has better performance than
hash set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
