Jackie-Jiang commented on code in PR #17145:
URL: https://github.com/apache/pinot/pull/17145#discussion_r2578601039
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/PhysicalTableConfig.java:
##########
@@ -26,4 +27,40 @@
* This is empty by design and more docs would be added as features are added.
*/
public class PhysicalTableConfig extends BaseJsonConfig {
+ @JsonProperty("isFederated")
+ boolean _isFederated;
Review Comment:
If the federation concept is within logical table only, the config should
reside in the `LogicalTableConfig`. `isFederated` property should not be
associated with a physical table. E.g. what if a physical table is federated in
one logical table, but not the other one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
