noob-se7en commented on issue #17260: URL: https://github.com/apache/pinot/issues/17260#issuecomment-3608649432
> When multiple stream support was added in https://github.com/apache/pinot/pull/13790, it assumes the partition id for a given stream can never go over 10000. This assumption cannot be held for certain custom stream plugins. I was unaware that the above assumption was wrong while creating the follow up PRs and went ahead based on this comment: https://github.com/apache/pinot/blame/8bfb907db9eeb29ea3f494f435aa2fa781378db1/pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java#L58-L60 ``` // For partition from different topics, we pad then with an offset to avoid collision. The offset is far higher // than the normal max number of partitions on stream (e.g. 512). public static final int PARTITION_PADDING_OFFSET = 10000; ``` > https://github.com/apache/pinot/pull/15957 fixed the problem by always checking if it is single stream before applying the modulo operation in But this does not fix the actual problem right? I am not sure if the padding approach is the best. Considering that the issue is with the LLCSegmentName naming convention here, maybe we should explore a different naming strategy for multi-stream tables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
