lnbest0707-uber commented on issue #17260: URL: https://github.com/apache/pinot/issues/17260#issuecomment-3630265360
> > But this does not fix the actual problem right? > > Agree. This is just a workaround to not break single stream case, which is much more common than multiple streams. > > > I am not sure if the padding approach is the best. Considering that the issue is with the LLCSegmentName naming convention here, maybe we should explore a different naming strategy for multi-stream tables. > > +1 on this. The root problem is to overloading partition id to represent multiple streams. cc [@lnbest0707-uber](https://github.com/lnbest0707-uber) [@ankitsultana](https://github.com/ankitsultana) Given the above problems, what's your opinion? There was one [proposal ](https://github.com/apache/pinot/pull/16494)to add topic name into the segment name but the community were a bit hesitated with it. On one side, it introduced many changes to the existing code. On the other side, it may increase the length of segment name and size of ideal state. Especially the ideal state, it could be very large with the uncontrolled kafka topic names. Maybe the solution could be slightly changing the segment naming format + keeping the index of the topic only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
