tarun11Mavani commented on code in PR #17405:
URL: https://github.com/apache/pinot/pull/17405#discussion_r2645558574
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java:
##########
@@ -613,7 +622,13 @@ public SegmentUploadContext(PinotTaskConfig
pinotTaskConfig,
Map<String, String> configs = pinotTaskConfig.getConfigs();
_tableNameWithType = configs.get(MinionConstants.TABLE_NAME_KEY);
_uploadURL = configs.get(MinionConstants.UPLOAD_URL_KEY);
- _authProvider =
AuthProviderUtils.makeAuthProvider(configs.get(MinionConstants.AUTH_TOKEN));
+ // Prefer the runtime minion AuthProvider; fallback to token if needed.
+ AuthProvider runtimeProvider = MINION_CONTEXT.getTaskAuthProvider();
Review Comment:
Can move this method out BaseTaskExecutor or MinionUtil to avoid
duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
