cypherean commented on PR #17405: URL: https://github.com/apache/pinot/pull/17405#issuecomment-3771852281
> I'd do it in a different way, where each task can override the auth token if necessary. > > Currently auth token is set when starting a task (in `TaskFactoryRegistry.runInternal()`). Instead, we shouldn't set it, but check if that is explicitly provided. When explicitly provided, use it as the auth provider; if not, fall back to the minion global one. Good catch, thanks. Fixed it to check for explicit token first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
