J-HowHuang commented on code in PR #17424:
URL: https://github.com/apache/pinot/pull/17424#discussion_r2648502649
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -247,4 +250,12 @@ public void onBecomeDroppedFromError(Message message,
NotificationContext contex
}
}
}
+
+ @Override
+ public ExecutorService getExecutorService(String resourceName, String
fromState, String toState) {
Review Comment:
Transition type means "from which state to which state". For each pair of
states, this method will be called with it at most once, to register the thread
pool to that transition type.
This would not be an issue since it constructs the thread pools for the
transitions in the new `ServerThreadPoolManager` at server start, then reuse
them throughout the server lifetime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
