J-HowHuang commented on code in PR #17424:
URL: https://github.com/apache/pinot/pull/17424#discussion_r2648587797
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -247,4 +250,12 @@ public void onBecomeDroppedFromError(Message message,
NotificationContext contex
}
}
}
+
+ @Override
+ public ExecutorService getExecutorService(String resourceName, String
fromState, String toState) {
Review Comment:
Get it. Example configs:
|`helix.transition.thread.pool.size` |
`helix.transition.consuming.thread.pool.size` | result |
| -------- | ------- | ----- |
| null | null | original path |
| null | 10 | transition from/to consuming use the new thread pool,
others use the original |
| 40 | null | transition from/to consuming use the original path,
others use the new thread pool |
| 40 | 10 | all transitions use the new thread pools
Added a note there will be no effect on the change from `null` to `40` or
from `40` to `null`, because the thread pool would be registered via
`getExecutor` upon the first time a transition type is seen, and will not be
changed after that. But the change from `40` to `10`, for example, is effective
because it just changes the core size and max size of the thread pool, not
changing the thread pool object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
