xiangfu0 commented on code in PR #17458:
URL: https://github.com/apache/pinot/pull/17458#discussion_r2678219411
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -268,18 +268,21 @@ protected void
revertCurrentSegmentUpsertMetadata(IndexSegment oldSegment, Threa
oldSegment.getSegmentName());
for (Map.Entry<Object, RecordLocation> obj :
_previousKeyToRecordLocationMap.entrySet()) {
IndexSegment prevSegment = obj.getValue().getSegment();
+ IndexSegment currentLocation =
_primaryKeyToRecordLocationMap.get(obj.getKey()).getSegment();
Review Comment:
is it possible this `_primaryKeyToRecordLocationMap.get(obj.getKey())` give
null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
