xiangfu0 commented on code in PR #17458:
URL: https://github.com/apache/pinot/pull/17458#discussion_r2678442058
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -1604,11 +1604,22 @@ public static void checkForDuplicates(List<String>
columns) {
}
}
- public static boolean checkForInconsistentStateConfigs(TableConfig
tableConfig) {
- return tableConfig != null && tableConfig.getUpsertConfig() != null &&
tableConfig.getReplication() > 1 && (
- tableConfig.getUpsertConfig().getMode() == UpsertConfig.Mode.PARTIAL
|| (
- tableConfig.getUpsertConfig().isDropOutOfOrderRecord()
- && tableConfig.getUpsertConfig().getConsistencyMode() ==
UpsertConfig.ConsistencyMode.NONE));
+ /**
+ * Checks if the table config has inconsistent state configurations that
could cause
+ * data inconsistency during force commit/reload operations.
+ *
+ * @param tableConfig the table config to check, may be null
+ * @return true if the table has inconsistent state configs, false if
tableConfig is null or no issues found
+ */
+ public static boolean checkForInconsistentStateConfigs(@Nullable TableConfig
tableConfig) {
+ UpsertConfig upsertConfig = tableConfig.getUpsertConfig();
Review Comment:
then we should remove the `@Nullable` in line 1614?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
