swaminathanmanish commented on code in PR #17632:
URL: https://github.com/apache/pinot/pull/17632#discussion_r2802337393
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##########
@@ -191,9 +197,20 @@ public static Map<String, String> getPushTaskConfig(String
tableName, Map<String
break;
}
} else {
- LOGGER.warn("Local output dir found, defaulting to TAR: {}.",
outputSegmentDirURI);
- singleFileGenerationTaskConfig.put(BatchConfigProperties.PUSH_MODE,
- BatchConfigProperties.SegmentPushType.TAR.toString());
+ boolean allowMetadataPushWithLocalFs = Boolean.parseBoolean(
Review Comment:
Why is the new param needed. Instead of this extra param -
ALLOW_METADATA_PUSH_WITH_LOCAL_FS, can we not just take the metadata push path
when configured regardless of LOCAL_FS or not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
