shounakmk219 commented on code in PR #17632:
URL: https://github.com/apache/pinot/pull/17632#discussion_r2802535259
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##########
@@ -191,9 +197,20 @@ public static Map<String, String> getPushTaskConfig(String
tableName, Map<String
break;
}
} else {
- LOGGER.warn("Local output dir found, defaulting to TAR: {}.",
outputSegmentDirURI);
- singleFileGenerationTaskConfig.put(BatchConfigProperties.PUSH_MODE,
- BatchConfigProperties.SegmentPushType.TAR.toString());
+ boolean allowMetadataPushWithLocalFs = Boolean.parseBoolean(
Review Comment:
Its risky for multi node setup where segment download url will point to a
local path (mostly on the minion) and server will look for it on their own
local fs for downloading the segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
