shauryachats commented on code in PR #17676:
URL: https://github.com/apache/pinot/pull/17676#discussion_r2810605378
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java:
##########
@@ -166,6 +167,9 @@ public TimeSeriesBlock handleTimeSeriesRequest(String lang,
String rawQueryParam
timeSeriesBlock =
_queryDispatcher.submitAndGet(requestContext.getRequestId(), dispatchablePlan,
timeSeriesRequest.getTimeout().toMillis(), requestContext);
+
+ long endToEndTimeMs = System.currentTimeMillis() - queryStartTime;
Review Comment:
Moved it to the `finally` block. The error cases would still have zero time
used since we only throw exceptions.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/TimeSeriesExchangeReceiveOperator.java:
##########
@@ -210,6 +218,21 @@ private void mergeStats(Map<String, String>
aggregatedStats, Map<String, String>
}
}
}
+
+ for (DataTable.MetadataKey statKey : MIN_STATS_KEYS) {
+ String key = statKey.getName();
+ String existingValue = aggregatedStats.getOrDefault(key, "0");
Review Comment:
Good catch! Updated to `Long.MAX_VALUE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
