krishan1390 commented on PR #17707: URL: https://github.com/apache/pinot/pull/17707#issuecomment-3906878797
@xiangfu0 given group commit is already enabled by default, this PR itself doesn't reduce the memory allocation from roughly O(concurrency * IS) to O(batches * IS) right ? This PR reduces the memory allocation by half in the happy path right ? This is also a good improvement but just confirming that the description probably needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
