Jackie-Jiang commented on code in PR #17707:
URL: https://github.com/apache/pinot/pull/17707#discussion_r2824950594
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1137,6 +1174,26 @@ Set<Integer> getPartitionIds(StreamConfig streamConfig)
@VisibleForTesting
Set<Integer> getPartitionIds(List<StreamConfig> streamConfigs, IdealState
idealState) {
+ return getPartitionIdsWithIdealState(streamConfigs, () ->
idealState)._partitionIds;
+ }
+
+ private Set<Integer> getPartitionIds(List<StreamConfig> streamConfigs,
String realtimeTableName) {
Review Comment:
Unused
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -689,13 +686,34 @@ private void commitSegmentMetadataInternal(String
realtimeTableName,
LOGGER.info("Updating Idealstate for previous: {} and new segment: {}",
committingSegmentName,
newConsumingSegmentName);
long startTimeNs3 = System.nanoTime();
+ IdealState idealState;
Review Comment:
(nit) Move this to line 695
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -797,7 +815,7 @@ private SegmentZKMetadata
updateSegmentZKMetadataToCommitting(String realtimeTab
// Step 2: Create new segment metadata
@Nullable
- private String createNewSegmentMetadata(TableConfig tableConfig, IdealState
idealState,
+ private String createNewSegmentMetadata(TableConfig tableConfig,
Review Comment:
(nit) Reformat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
