Jackie-Jiang commented on code in PR #17602:
URL: https://github.com/apache/pinot/pull/17602#discussion_r2824091730
##########
pinot-integration-tests/pom.xml:
##########
@@ -89,11 +89,11 @@
<configuration>
<skipTests>false</skipTests>
<includes>
+
<include>**/org/apache/pinot/integration/tests/E*Test.java</include>
Review Comment:
Revert?
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java:
##########
@@ -55,16 +57,31 @@ public class SegmentBuildTimeLeaseExtender {
private final ServerSegmentCompletionProtocolHandler _protocolHandler;
public static void initExecutor() {
- _executor = new ScheduledThreadPoolExecutor(1);
- LOGGER.info("Initialized segment build time lease extender executor");
+ synchronized (EXECUTOR_LOCK) {
Review Comment:
I don't follow the change in this file. Is this for testing setup purpose?
If so, we should modify test instead, not changing production code
##########
pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml:
##########
@@ -53,6 +53,10 @@
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
</dependency>
+ <dependency>
Review Comment:
Is this required? We don't use slf4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
