cbalci commented on code in PR #17731:
URL: https://github.com/apache/pinot/pull/17731#discussion_r2835391944
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -409,6 +409,9 @@ private void checkAuthorization(RequesterIdentity
requesterIdentity, RequestCont
HttpHeaders httpHeaders, QueryEnvironment.CompiledQuery compiledQuery,
AtomicBoolean rlsFiltersApplied) {
Set<String> tables = compiledQuery.getTableNames();
if (tables != null && !tables.isEmpty()) {
+ // Validate that physical tables are not queried with multi-cluster
routing enabled
+ validatePhysicalTablesWithMultiClusterRouting(tables,
compiledQuery.getOptions());
Review Comment:
This looks a bit out of place inside the authorization check. Maybe we can
move it into the compileQuery method for consistency between engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
