chenboat commented on code in PR #17731:
URL: https://github.com/apache/pinot/pull/17731#discussion_r2842332587
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -261,6 +262,34 @@ protected TableAuthorizationResult
hasTableAccess(RequesterIdentity requesterIde
return tableAuthorizationResult;
}
+ /**
+ * Validates that physical tables are not being queried with
enableMultiClusterRouting=true.
Review Comment:
Is this typo? If enableMultiClusterRouting=true, I suppose we want to enable
multi cluster routing and thus query federation on the underlying physical
tables? In general, I suggest to use positive term (i.e., validates that
physical tables can be queries if and only if ...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
