timothy-e commented on code in PR #17749:
URL: https://github.com/apache/pinot/pull/17749#discussion_r2847687902
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -575,11 +574,11 @@ public long getPartitionEndToEndIngestionDelayMs(int
partitionId) {
public long getPartitionIngestionDelayMs(int partitionId) {
IngestionInfo ingestionInfo = _ingestionInfoMap.get(partitionId);
long ingestionTimeMs = 0;
- if ((ingestionInfo != null) && (ingestionInfo._ingestionTimeMs > 0)) {
- ingestionTimeMs = ingestionInfo._ingestionTimeMs;
+ if (ingestionInfo == null || ingestionInfo._ingestionTimeMs < 0) {
+ return 0;
Review Comment:
Wouldn't that only happen if the consumer never created an `IngestionInfo` /
updated the `_ingestionInfoMap`? I feel like that's a seperate problem with the
consumer's bootstrapping, so trying to capture that in ingestion delay doesn't
seem right to me. Open to suggestions though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
