noob-se7en commented on code in PR #17749:
URL: https://github.com/apache/pinot/pull/17749#discussion_r2849162773
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -575,11 +574,11 @@ public long getPartitionEndToEndIngestionDelayMs(int
partitionId) {
public long getPartitionIngestionDelayMs(int partitionId) {
IngestionInfo ingestionInfo = _ingestionInfoMap.get(partitionId);
long ingestionTimeMs = 0;
- if ((ingestionInfo != null) && (ingestionInfo._ingestionTimeMs > 0)) {
- ingestionTimeMs = ingestionInfo._ingestionTimeMs;
+ if (ingestionInfo == null || ingestionInfo._ingestionTimeMs < 0) {
+ return 0;
Review Comment:
There has been cases where consumer ends up in deadlock or consumer thread
just died.
As per this Pr's change the lag will be just reported as zero, and that to
me seems definitely we shouldnt do. Worst case we can just report what we were
previously doing -> (current timestamp - 0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
