Jackie-Jiang commented on code in PR #17696:
URL: https://github.com/apache/pinot/pull/17696#discussion_r2894418403
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -257,6 +262,16 @@ public static class UpsertCompactionTask {
* number of segments to query in one batch to fetch valid doc id
metadata, by default 500
*/
public static final String NUM_SEGMENTS_BATCH_PER_SERVER_REQUEST =
"numSegmentsBatchPerServerRequest";
+
+ /**
+ * Valid doc ids comparison mode used by the executor only (generator
unchanged). Values: UNSAFE, EQUAL,
+ * MOST_VALID_DOCS. UNSAFE = use first server with matching CRC and READY;
EQUAL = require all replicas
+ * to have the same valid doc set (default); MOST_VALID_DOCS = use replica
with most valid docs.
+ */
+ public static final String VALID_DOC_IDS_COMPARISON_MODE_KEY =
"validDocIdsComparisonMode";
Review Comment:
Make the key consistent with enum: `validDocIdsConsensusMode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
