vincentchenjl commented on a change in pull request #4761: [TE] Centralized
cache proof-of-concept for anomaly detection via Couchbase
URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341370198
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/algorithm/DimensionWrapper.java
##########
@@ -238,6 +244,16 @@ public DetectionPipelineResult run() throws Exception {
this.config.getId(), nestedMetrics.size(),
MAX_DIMENSION_COMBINATIONS));
}
+ // don't use in-memory cache for dimension exploration, it will cause
thrashing
+ if (CacheConfig.useCentralizedCache()) {
+ if (this.cachingPeriodLookback >= 0) {
+ this.provider.fetchTimeseries(nestedMetrics.stream()
Review comment:
Are we doing cache warm-up here? If yes, can this call be slow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
