vincentchenjl commented on a change in pull request #4761: [TE] Centralized cache proof-of-concept for anomaly detection via Couchbase URL: https://github.com/apache/incubator-pinot/pull/4761#discussion_r341371716
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/loader/DefaultTimeSeriesLoader.java ########## @@ -36,16 +37,18 @@ private final MetricConfigManager metricDAO; private final DatasetConfigManager datasetDAO; - private final QueryCache cache; + private final QueryCache queryCache; + private final DefaultTimeSeriesCache timeSeriesCache; Review comment: My suggestion here is that we should put `timeSeriesCache` in `DefaultDataProvider`, as this cache is in the same level as the memory cache we had, from the perspective of the architecture. It is much easier to understand if all the logic of loading from cache or data source is in one place. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
